Cannot install pjs on windows

[Bartvds]

It bails on the npm install script (windows node.js users aren't required to have make).

I looked into the makefile but I'm not quite sure why you need the npm script at all.

It doesn't do that much and of course it is labelled as a antipattern, especially if it is not cross platform. (see note on https://www.npmjs.org/doc/scripts.html).

Could it be removed from normal use?

Note: psj was installed via parsimmon.

[jneen]

I am happy to look at a pull request. I have no way to test things on Windows. isaacs may think otherwise, but I think it's kind of silly to develop on a computer without some version of make :.

[jneen]

@Bartvds can you try it with that commit? I think I figured it out. I'd tried to add it statically before but ended up publishing a package without the built files in it, since npm magically read my .gitignore file. Adding the noop .npmignore seems to have fixed it.

[Bartvds]

Thanks for looking in it.

We choose to stay within the 100% cross-platform capable node+npm eco-system and not introduce external tooling as it brings unnecessary complexity: node.js works great as universal local scripting-host, and there are a tonne of build systems on npm: like Jake, Grunt, Gulp, Broccoli, ShellJS are all popular. But let's not go into that here (we could if you like, but by email).

Anyway, I see your new commit: prepublish is made for this thing.

$ npm install git://github.com/jayferd/pjs
pjs@5.1.0 node_modules\pjs

Looks good, I see 5.1.0content as expected.

On the .npmignore: what you describe is documented behaviour (so I learned same way once :). For pjs you might want to add some more things to it: it probably should ignore the ./test, ./src, Makefile etc (consumers of the npm package have no use for those files). You can verify what it packages by using the npm pack command.

I'm looking forward to seeing this pjs 5.1.0 bubble up to parsimmon's npm package.