Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dask array compatibility layer #131

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add dask array compatibility layer #131

wants to merge 6 commits into from

Conversation

jni
Copy link
Owner

@jni jni commented Jun 28, 2021

cc @GenevieveBuckley

Description

Type of change

  • Bug-fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

References

How has this been tested?

  • example: the test suite for my feature covers cases x, y, and z
  • example: all tests pass with my change

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • If I included new strings, I have used trans. to make them localizable.
    For more information see our translations guide.

@jni
Copy link
Owner Author

jni commented Jun 28, 2021

TODO: add tests to ensure results are unchanged between numpy with "unique_junctions=False" and dask.

@GenevieveBuckley
Copy link
Collaborator

TODO:

  • CI tests are failing because dask is not available in the test environment. We need dask and dask-image to be there.

@GenevieveBuckley
Copy link
Collaborator

GenevieveBuckley commented Jul 7, 2021

I've got some bad news about the tests @jni - there's a problem besides the test environment dependencies

@jni
Copy link
Owner Author

jni commented Jul 8, 2021

This is the line that install things when running tests:

pip install .[all,testing]

So dask needs to be added to:

skan/setup.cfg

Line 65 in 97a217d

testing =

@GenevieveBuckley
Copy link
Collaborator

Hmm, would have thought that was being handled by the all part of that. I've added dask (& dask-image) to the testing requirements in setup.cfg and we'll see how that goes.

Thanks for checking into it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants