Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Turnip::Node::Tag#tag_names #186

Merged
merged 1 commit into from
Oct 3, 2016
Merged

Add Turnip::Node::Tag#tag_names #186

merged 1 commit into from
Oct 3, 2016

Conversation

gongo
Copy link
Collaborator

@gongo gongo commented Oct 3, 2016

Problems

Until ver 2.1.1, tags method that has been implemented in Feature, Scenario and ScenarioOutline returned Array of tag name. But, since GH-185, this return Array of Turnip::Node::Tag 🙇

Solve

New API tag_names:

scenario.tag_names # => ['foo1', 'foo2']

Instead of Turnip::Builder::Tag#tags (Back compatibility)
@gongo gongo self-assigned this Oct 3, 2016
@gongo gongo merged commit 73f71d0 into master Oct 3, 2016
@gongo gongo deleted the tag_names branch October 3, 2016 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant