Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong encoding for URL / bytes. #4

Closed
Ferada opened this issue Apr 13, 2016 · 3 comments
Closed

Wrong encoding for URL / bytes. #4

Ferada opened this issue Apr 13, 2016 · 3 comments

Comments

@Ferada
Copy link
Contributor

Ferada commented Apr 13, 2016

(cl-qrencode:encode-png "herpderp")

results in a QR code that is being decoded to

herpl�rp

(with zbarimg, an Android phone app and e.g. https://zxing.org/w/decode.jspx).

With the same settings, e.g. using qrencode -8 -l M "herpderp" -o qrcode-correct.png the data is decoded correctly, giving the resulting raw bytes

40 86 86 57 27 06 46 57   27 00 ec 11 ec 11 ec 11

whereas the wrong sequence is

40 86 86 57 27 06 c8 57   27 00 ec 11 ec 11 ec 11

With a bit of tracing I now think this is after the bit stream generation, so possibly in the EC coding functions.

(N.b. this is using an AFAIK fixed version of the padding, c.f. #5.)

@jnjcc
Copy link
Owner

jnjcc commented Apr 15, 2016

Thanks for your feedback.

I've been busy at work lately, will take a look at it this weekend.

@jnjcc
Copy link
Owner

jnjcc commented May 2, 2016

Fixed in b205f14.

Thanks again for your feedback.

@jnjcc jnjcc closed this as completed May 2, 2016
@Ferada
Copy link
Contributor Author

Ferada commented May 2, 2016

\o/ thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants