Reimplement list activity with RecyclerView #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also refactor the list item view a bit to include two separate text views, one for headline and one for byline.
| public class ArticleAdapter extends RecyclerView.Adapter<ArticleAdapter.ViewHolder> { | ||
| private ArrayList<Article> mArticles; | ||
|
|
||
| public static class ViewHolder extends RecyclerView.ViewHolder { |
There was a problem hiding this comment.
hey! half my comments from the last PR are already addressed 8 hours ago!
There was a problem hiding this comment.
Not completely, but I expect there will be some amount of "it just works" while learning a framework. I'll report back on ViewHolder at some point.
There was a problem hiding this comment.
ok, let me know if you want the long story... it came about because of bad habits and slow xml parsing, but is now baked in the cake, so i think turned out maybe a little differently than it might have without those bumps
|
+1 clean, simple, easy to read, ready to ship |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactor the list item view a bit to include two separate text
views, one for headline and one for byline.