Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is with regard to issue #38
the openbsd port of jruby builds the libjffi-1.2.so the following way:
cc -o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/libjffi-1.2.so -pthread -shared -static-libgcc /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/Array.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/deprecated.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/Library.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/LongDouble.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/MemoryIO.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/Internals.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/CallContext.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/MemoryUtil.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/Memory.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/Invoke.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/LastError.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/FastNumericInvoker.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/Type.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/Foreign.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/FastIntInvoke.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/Exception.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/ClosureMagazine.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/Struct.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/FastLongInvoke.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/libffi-x86_64-openbsd/.libs/libffi_convenience.a
which dynamically links in libpthread, since that then links to libpthread.so.X.Y, and those major/minor
can change over time, I changed that compilation to link against the static libpthread like this:
cc -o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/libjffi-1.2.so -shared -static-libgcc /usr/lib/libpthread.a /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/Array.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/deprecated.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/Library.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/LongDouble.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/MemoryIO.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/Internals.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/CallContext.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/MemoryUtil.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/Memory.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/Invoke.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/LastError.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/FastNumericInvoker.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/Type.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/Foreign.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/FastIntInvoke.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/Exception.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/ClosureMagazine.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/Struct.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/jffi/FastLongInvoke.o /home/ports/pobj/amd64/jruby-9.1.6.0/jruby-9.1.6.0/jffi/build/jni/libffi-x86_64-openbsd/.libs/libffi_convenience.a