Select first match instead of last when searching for maximum version of .so file on linux #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That last commit looks like it broke the if conditional. I wonder if this change will help us with our issues loading 32-bit instead of 64-bit libraries on Fedora. Will try to review and merge today. |
|
This is exactly why I made this change, otherwise I can't use jnr on Fedora. |
|
That's excellent. I figured there was just some library path juggling necessary but I had not had a chance to fiddle with it. Let me know when you're happy with the PR and we'll get it in. |
|
It should be fine now |
|
Excellent! Thank you! |
headius
added a commit
that referenced
this pull request
Nov 8, 2014
Select first match instead of last when searching for maximum version of .so file on linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMHO the order of the libraryPath is important and libraries should come from the first location they can be found in.