Overhauled tests for numeric types #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Significantly improved tests for numeric types using boundary value analysis such that we cover all supported number types inside and beyond their bounds * Improved tests for enum types * Fixed a small bug that didn't allow for mapping primitive Java doubles using boxed Java Doubles and was assuming they were floats * Removed code from unimplemented feature that was meant to allow for enums to be mapped using longs in addition to ints, some code was existing but never did anything as a dedicated EnumLongConverter was required, this functionality can be added later if needed
…ed spec from written tests regarding numeric types and enums
… and will be used elsewhere in tests in the future
This was referenced Jan 9, 2022
basshelal
changed the title
|
Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doubles using boxed JavaDoubles and was incorrectly assuming they werefloatsenums to be mapped usinglongs in addition toints, some code was existing but never did anything as a dedicatedEnumLongConverterwould be needed to be added, this functionality can be added later if neededenums based on new findings and specification made from writing new tests