Overhauled tests for structure types containing structure types and pointers to them #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… numeric types. Removed now redundant tests in StructureTest.java and removed UnionTest.java entirely for this same reason, what remains are tests that will be overhauled in the future Modified GNUmakefile to build for nested directories.
… structure types and pointers to them. Added new method overloads for existing methods in Struct.java that are a little easier to use and more idiomatic in addition to the existing methods: * Struct.size() can take in just the Struct type's class like `Struct.size(MyStruct.class)` in addition to also passing in the Runtime if desired like `Struct.size(MyStruct.class, Runtime.getSystemRuntime())`. This makes it easier to use for quickly checking the size of a struct without needing to explicitly create a new one, though internally a new one is created using reflection. * Struct.inner() can take in just the Struct type's class like `inner(MyInnerStruct.class)`. This makes it look similar to `StructRef` which has the same signature in its constructor and the implementation (reflection construction using the default constructor that takes a Runtime argument) was indeed taken from there. Detailed JavaDoc comments have been added to both the new methods and the old ones
|
Wow, this is great... even added documentation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test suite overhaul for structure types (struct and union) containing structure types and pointers to them.
Added new method overloads for existing methods in Struct.java that are a little easier to use and more idiomatic in addition to the existing methods:
Struct.size()can take in just the Struct type's class likeStruct.size(MyStruct.class)in addition to also passing in the Runtime if desired likeStruct.size(MyStruct.class, Runtime.getSystemRuntime()). This makes it easier to use for quickly checking the size of a struct without needing to explicitly create a new one, though internally a new one is created using reflection.Struct.inner()can take in just the Struct type's class likeinner(MyInnerStruct.class). This makes it look similar toStructRefwhich has the same signature in its constructor and the implementation (reflection construction using the default constructor that takes a Runtime argument) was indeed taken from there.Detailed JavaDoc comments have been added to both the new methods and the old ones
This modifies and uses changes from #295, merge that one first before this one!