StructRef inner class. #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rect memory and writes it's address to Struct memory.
|
depends on #82 |
headius
approved these changes
Sep 26, 2016
There was a problem hiding this comment.
Looks ok to me. Seems to logically mirror the other Ref type fields. Would like @henriquemotaesteves and anyone else actively working on jnr-ffi to have a look too.
|
@headius already done that |
|
@goto1134 Oh of course. I have no remaining reservations. |
|
@goto1134 I'd like to get at least one other person to weigh in. Are you opposed to pushing this to a 2.1.x release to give it a bit more review time? I'd like to get 2.1 out today. |
|
@headius that's ok |
|
@henriquemotaesteves I'll probably go ahead and merge this soon unless you have concerns. |
|
This is too scary to do for the JRuby 9.1.6.0 release today, but I'll merge it afterwards and do a snapshot for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It addresses to a Struct or array of Structs.