Fixes #69 - Gather writes are broken. #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correctly looping over the buffers, returning as soon as one of the writes is not complete. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Closed
gregw
reviewed
Mar 19, 2019
| int written = write(buffer); | ||
| result += written; | ||
| if (written < remaining) { | ||
| break; |
There was a problem hiding this comment.
Is it correct to immediately break? rather than try again at least once?
Consider an impl that can only write a fixed size at a time (say 1024), but it can take many calls each slicing off 1024?
Isn't it better to break only when no progress is made? ie written==0
There was a problem hiding this comment.
@gregw good point. I have changed the code to reflect your review. Good?
Optimized gathered write after review. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
|
@headius any chance of getting this in a release? |
prd-fox
added a commit
to Consensys/tessera
that referenced
this pull request
Feb 5, 2020
Update the JNR unix socket library to fix an issue with writing to the socket when the OS buffer is full. Details of the fix at jnr/jnr-unixsocket#70
prd-fox
added a commit
to Consensys/tessera
that referenced
this pull request
Feb 5, 2020
Update the JNR unix socket library to fix an issue with writing to the socket when the OS buffer is full. Details of the fix at jnr/jnr-unixsocket#70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly looping over the buffers, returning
as soon as one of the writes is not complete.
Signed-off-by: Simone Bordet simone.bordet@gmail.com