Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Add a 'run tasks started' signal to TaskManagerBase and minor behavior change to LIFOTaskManager #11

Merged
merged 4 commits into from
Oct 17, 2023
Merged

PR: Add a 'run tasks started' signal to TaskManagerBase and minor behavior change to LIFOTaskManager #11

merged 4 commits into from
Oct 17, 2023

Conversation

jnsebgosselin
Copy link
Owner

@jnsebgosselin jnsebgosselin commented Oct 17, 2023 •
edited
Loading

  • Now TaskManagerBase will emit sig_run_tasks_started when a new batch of tasks is started. Note that the signal is not emitted when new tasks are added to the queue and pushed as pending tasks while the worker is still running tasks.
  • Now run_tasks is not systematically called when adding a new task to the LIFOTaskManager. This must be called explicitly after adding a task.
  • Expanded the tests for the taskmanagers module.

@jnsebgosselin jnsebgosselin added the enhancement New feature or request label Oct 17, 2023
@jnsebgosselin jnsebgosselin added this to the 0.4.0 milestone Oct 17, 2023
@jnsebgosselin jnsebgosselin self-assigned this Oct 17, 2023
@jnsebgosselin jnsebgosselin merged commit d5371cf into main Oct 17, 2023
1 check passed
@jnsebgosselin jnsebgosselin deleted the add_start_signal_to_taskmanager branch November 22, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jnsebgosselin jnsebgosselin

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jnsebgosselin