Use GitHub actions #76
Conversation
| matrix: | ||
| allow_failures: | ||
| - rvm: 1.8 | ||
| script: ./script/test |
There was a problem hiding this comment.
Why both introduce a new way to test on ci and not remove thr current way?
Otherwise. Looks good
There was a problem hiding this comment.
I'm going to clean this up - I wasn't sure if anybody still needs it to test the gem locally
There was a problem hiding this comment.
I've removed script/test 👍
lib/crack/json.rb
Outdated
| @@ -4,20 +4,32 @@ | |||
| # THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | |||
|
|
|||
| require 'strscan' | |||
| require 'psych' | |||
There was a problem hiding this comment.
I don't believe this change is in scope with ths pr
There was a problem hiding this comment.
if I remember correctly, I had to add this to fix a failing test with one of the Ruby versions. I'm going to check it again and come back with the results
There was a problem hiding this comment.
Without 644b0f7 / #74 , the CI fails for Ruby 3.1, 3.2, 3.3 and JRuby equivalents, a sample run could be found here: https://github.com/kiskoza/crack/actions/runs/7622992428/job/20762118748
How should we resolve this?
- Keep the commit fixing the code
- Keep the Ruby versions within the CI matrix, but merge them as failing
- Remove the newer Ruby versions and add them along the fix in a new PR
I would prefer 1 or 2 and wouldn't recommend doing 3, but happy to go the path you find the best
There was a problem hiding this comment.
I think simplest is to merge this with passing ci (comment out or allow failures) then in fix pr add the failing matrix options
There was a problem hiding this comment.
Are you interested in being added as a maintainer? You seem committed and thoughtful, so...
There was a problem hiding this comment.
I've updated the CI matrix to allow failures for recent Ruby versions, it should be fine now. I'd happily help as being a maintainer as well.
kiskoza
force-pushed
the
github-actions
branch
from
571aceb
to
47220e7
Compare
|
@kiskoza You've been granted the respect and responsibility of a maintainer by myself and @jnunemaker :) Thanks for your assistance! |
I was doing some maintanence tasks for an other gem and when I added the new Ruby 3.3 to the CI pipeline, I saw a few deprecation warnings coming from this gem (as one of our dependencies). I saw that there's a PR already to get rid of the warning (#75), but the project lacks of a working pipeline to verify that change (travis seems to be unavailable). Looking at the open pull requests, there were others trying to make sure that the gem works with recent Ruby versions (#74, #71).
Fast-forward to my PR: I'm trying to add Github Actions as it seems to be a reliable pipeline for open source repositories hosted on Github.
The changes I made:
.travis.ymlwith.github/workflows/test.ymlI hope you'll find this PR helpful. Let me know if you need anything else before you can merge it in.
(edit) And example of a green pipeline could be found here https://github.com/kiskoza/crack/actions/runs/7384963412