Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] QR codes are inverted #830

Closed
jacekowski opened this issue Mar 25, 2023 · 7 comments
Closed

[BUG] QR codes are inverted #830

jacekowski opened this issue Mar 25, 2023 · 7 comments
Labels
bug Something isn't working
Milestone

Comments

@jacekowski
Copy link
Contributor

Currently the QR codes are drawn inverted. This limits compatibility severely (most scanners will not read inverted QR codes).

Ideally the code should have white border that is at least 4 modules wide as well.

@jacekowski jacekowski added the bug Something isn't working label Mar 25, 2023
@joBr99
Copy link
Owner

joBr99 commented Mar 25, 2023

QR-Codes are drawn as is by the Nextion firmware, there is nothing I can do about this. I'm just setting the string of the QR-Code.

@jacekowski
Copy link
Contributor Author

Swapping parameters (defaultBcoColor and 65535) in https://github.com/joBr99/nspanel-lovelace-ui/blob/main/HMI/n2t-out/cardQR.txt#L613 this line fixes the issue and codes are drawn correctly.

@randybb
Copy link

randybb commented Mar 25, 2023

This is the reason why any of my android devices cannot read these QR codes as I have mentioned long time ago on discord?

@jacekowski
Copy link
Contributor Author

That would be a yes.

Try installing http://jacekowski.net/nspanel/lui-release-qr.tft (i've just swapped QR colours)

@randybb
Copy link

randybb commented Mar 25, 2023

I have a different display, but I faked it a bit - took a photo, inverted colors and was able to scan it!!! :D

@joBr99
Copy link
Owner

joBr99 commented Mar 25, 2023

thanks, will look into this and add the fix to the HMIs

joBr99 added a commit that referenced this issue Mar 27, 2023
@joBr99
Copy link
Owner

joBr99 commented Mar 27, 2023

swapped the colors in the EU Version; US-L and US-P will follow

@joBr99 joBr99 closed this as completed Mar 27, 2023
joBr99 added a commit that referenced this issue Mar 27, 2023
github-actions bot pushed a commit that referenced this issue Mar 27, 2023
@joBr99 joBr99 added this to the 4.1.X milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants