Fix __version__ and get rid of __version_info__ #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Since both of those vars were wrong for ages, it shoudn't do any harm. - __version_info__ is ment to be used to programatically compare versions as described here: https://softwareengineering.stackexchange.com/questions/375922/whats-the-version-info-function-in-a-pypi-package - An alternative to removing it would be to implement a oneliner creating the 3-digit tuple as described in above link. - Starting with Python 3.8. there are better and recommended ways to handle package versioning: https://docs.python.org/3/library/importlib.metadata.html#distribution-versions
|
I'd lean more towards the oneliner for version_info, incase someone wants to use it, although i dont see much use for it 😅 |
|
Hi Anssi, thanks for giving feedback so quickly! OK, is fine with me as well. Yeah, why not, actually it's a simple oneline-comprehension thing with nothing special/version-dependent in it. I will add it. I'll wait a day or so to give @alifhughes a chance to have a quick look. |
- Add in __version_info__ again and use a generator expression to create the tuple. - Will work with our regular versioning (1.1.1), - but won't if non-digit characters are used (1.1.1-rc1) - The latter shouldn't be a problem since we don't usually do that.
|
Hey guys, sorry for the delay - looks good to me!
I'd agree, best to keep these things even though I don't see too much of a use of it myself. |
alifhughes
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing
__version__shouldn't hurt, removing__version_info__entirely is a proposal. Tell me what you think @AnssiAhola and @alifhughes.Some details in the commit message.