-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added remove_release to collection folder #88
added remove_release to collection folder #88
Conversation
I vote for add_release vs remove_release. Thanks @AnssiAhola, hope I will manage to test tomorrow or Thursday morning. |
What I dont understand from reading the discogs api docs you posted @AnssiAhola: It will remove the release instance from a folder, ok, but when removing from the uncategorized folder, I think the one with folder id 0, does it mean it will be removed from the collection entirely? That right? It would make sense but it's not entirely clear to me from reading the doc. Update: Ok that was silly, we give the instance id in the url_ |
…ub.com/AnssiAhola/discogs_client into remove_instance_from_collection_folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this so @raratiru can use it and do docs later on.
Thank you, this is a great addition! |
@raratiru This will be merged and (hopefully) released tomorrow if everything goes to plan 🤞 |
Implements this API as requested by @raratiru in #86
Not the most elegant solution but it works 🤷
@JOJ0 @alifhughes
If you could check this and test it, I'd appreciate it 🙂
Not sure ifdelete_instance
is good name for the method, maybedelete_release
to be consistent? Although it needsCollectionItemInstance
as theinstance id
is required in the url.Maybe it should be
remove_release
orremove_instance
like @raratiru suggested?Any suggestions are appreciated! 😅
Usage: