Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#223: Fix waveform length when merging pulses #225

Closed
wants to merge 2 commits into from
Closed

#223: Fix waveform length when merging pulses #225

wants to merge 2 commits into from

Conversation

phlipped
Copy link
Contributor

Fixes issue #223

@phlipped
Copy link
Contributor Author

While I'm here ... It seems to me that the if-blocks like "if (tNow < tNext1) ..." (lines 3233, 3250, 3267) will never get executed, and can be safely removed.

tNow will always be equal to the smaller of tNext1 and tNext2 (because of lines 3282,3283. This is also true at first iteration - tNow is 0, and at least one of tNext1 and tNext2 must be 0). Therefore, if (tNext1 < tNext2) (line 3229), then (tNow == tNext1), and the conditional (tNow < tNext1) (line 3233) will always be false. The same idea applies to the other two places (lines 3250 and 3267)

@joan2937
Copy link
Owner

joan2937 commented Nov 3, 2018

This fails a couple of tests in x_pigs and x_pipe which should pass. I'll need to revisit this at a later date.

@guymcswain guymcswain mentioned this pull request Jan 26, 2020
@guymcswain guymcswain closed this Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants