Add support for arm64 and RPi4 model B #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base messages consist of four uint32 integers. Wrongly, integers are declared as a four-element uintptr_t array. The 16 bytes are written directly by recv(). This works great for arm32, but on arm64 uintptr_t is 64 bit (8 bytes). This patch reads four 32-bit integers and writes them into the uintptr_t array.
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I got pigpio working on my new RPI4 Model B running tumbleweed (arm64!) after some patches.
Detection added.
There is a bug for arm64 in pthSocketThreadHandler.
You seem to send four integers as base messages.
These are declared as an array of four uintptr_t and recv() writes 16 bytes directly into that array.
This works for arm32, where uintptr_t is 32 bit (4×4=16), but breaks arm64 (8×4=32).
The patch reads 4 uint32_t and places them in the uintptr_t array.
It is a workaround.
Better also add ntohl()s, as arm can run in LE or BE.
BR Alex Simon