gpioCfgSetInternals now returns PI_INITIALISED after gpioInitialise #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves joan2937#455 with the discussion with @guymcswain that gpioCfgSetInternals() should return an error if gpioInitialise() has been called previously to report that it's no longer possible, for example, to disable signal handling. If successful it returns 0 as before. Tested it by calling gpioCfgSetInternals, gpioInitialise, gpioCfgSetInternals and reports 0 and -32 which looks OK.
Fixed the documentation that the command set_PWM_range() actually returns the actual range. This resolves joan2937#453.
|
Fixed also doc that set_PWM_range() returns the actual range. This resolves #453. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #455 with the discussion with @guymcswain that
gpioCfgSetInternals() should return an error if gpioInitialise()
has been called previously to report that it's no longer possible,
for example, to disable signal handling. If successful it returns
0 as before. Tested it by calling gpioCfgSetInternals, gpioInitialise,
gpioCfgSetInternals and reports 0 and -32 which looks OK.