Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fetch test #15

Merged
merged 4 commits into from
Aug 8, 2021
Merged

Feature/fetch test #15

merged 4 commits into from
Aug 8, 2021

Conversation

joanafbrito
Copy link
Owner

Description

Add Only one user ( traveler ) get request
fix the indentation in the fetch file
Create updateCurrentUser function
Add the right name to the parameter in the Traveler Class
Tested api instantiating one user id to see if it is working the way I expected

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor feature (non-breaking change that modifies existing work)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • open index.html
  • console.log()
  • dev tools
  • npm test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@joanafbrito joanafbrito linked an issue Aug 8, 2021 that may be closed by this pull request
1 task
Copy link
Collaborator

@Samantha-Stevens Samantha-Stevens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-Great psedocode and comments, I can follow your thought process well.
-You are making wonderful progress! Great work!

@Samantha-Stevens Samantha-Stevens merged commit b61a6b5 into main Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add get request for only one Traveler /user
2 participants