Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navbar links doesn't link to correct pages #4

Closed
ashleytqy opened this issue Feb 8, 2018 · 5 comments
Closed

Navbar links doesn't link to correct pages #4

ashleytqy opened this issue Feb 8, 2018 · 5 comments
Labels
assigned

Comments

@ashleytqy
Copy link
Contributor

ashleytqy commented Feb 8, 2018 •
edited
Loading

Currently, the Syllabus tab links to the daily schedule, and the Daily tab links to the syllabus page.

screen shot 2018-02-08 at 12 15 55 pm
@zdaisyz zdaisyz mentioned this issue Feb 8, 2018
Closed
@dorasun
Copy link
Contributor

dorasun commented Feb 8, 2018

Problem found under _includes/header.html, lines 10 and 11 have the wrong labels for the wrong links, see https://github.com/joannakl/cs480_s18/blob/gh-pages/_includes/header.html#L10-L11

@PhrydRhys PhrydRhys mentioned this issue Feb 8, 2018
Closed
@dmckenna24 dmckenna24 mentioned this issue Feb 11, 2018
Closed
@cr4zyafrican
Copy link
Contributor

Can confirm this issue with Chrome 63.0.3239.132

@mzguimaraes mzguimaraes mentioned this issue Feb 12, 2018
Closed
@gabegordon
Copy link
Contributor

This issue also occurs for me.
Using: Firefox 59.0b7

@Matthew-Herman
Copy link

I'd like to claim this issue.

@joannakl
Copy link
Owner

@Matthew-Herman : go ahead with the fix for this issue

@ashleytqy ashleytqy mentioned this issue Feb 17, 2018
Merged
joannakl added a commit that referenced this issue Feb 18, 2018
@joannakl
Merge pull request #51 from Matthew-Herman/gh-pages
ebd6d8e 
fixed #4, syllabus and navbar links now reference correct pages
@dayo-adebanjo dayo-adebanjo mentioned this issue Feb 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assigned
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@joannakl @dorasun @ashleytqy @gabegordon @Matthew-Herman @cr4zyafrican