Consumers set their own paths #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! It looks like the npm last published version doesn't contain this fix. Could you please check this? |
|
Consumers buy groceries. Do you mean users? You can also "consume" objects made by factories - but you cannot consume an interface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple code change requires all consumers, not just MS Windows, to set their own path to graphviz. The motivation behind decoupling tsviz from a fixed graphviz location to telling users to correctly set the path is an increase in flexibility and broader system compatibility.
closes #25 #24 #5
Thank you for tsviz and for reviewing this PR. I not quite understand bin v src with no tsconfig.json or npm run scripts to build so I just edited both.