Don't display flymake annotations when flymake is disabled #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…disabled * eglot.el (eglot-handle-notification): Check that flymake-mode is active before calling flymake report function.
joaotavora
approved these changes
May 12, 2020
| @@ -1580,7 +1580,7 @@ COMMAND is a symbol naming the command." | |||
| (t 'eglot-note)) | |||
| message `((eglot-lsp-diag . ,diag-spec))))) | |||
| into diags | |||
| finally (cond (eglot--current-flymake-report-fn | |||
| finally (cond ((and flymake-mode eglot--current-flymake-report-fn) | |||
There was a problem hiding this comment.
I'm not sure if we don't want to still set the "outstanding diagnostics" to nil. In this case. Not sure.
Other than that, looks good and simple.
bhankas
pushed a commit
to bhankas/emacs
that referenced
this pull request
Sep 18, 2022
…ke is disabled Also fix joaotavora/eglot#472. Copyright-paperwork-exempt: yes * eglot.el (eglot-handle-notification): Check that flymake-mode is active before calling flymake report function.
bhankas
pushed a commit
to bhankas/emacs
that referenced
this pull request
Sep 19, 2022
…ke is disabled Also fix joaotavora/eglot#472. Copyright-paperwork-exempt: yes * eglot.el (eglot-handle-notification): Check that flymake-mode is active before calling flymake report function.
bhankas
pushed a commit
to bhankas/emacs
that referenced
this pull request
Sep 19, 2022
Also fix #472. Copyright-paperwork-exempt: yes * eglot.el (eglot-handle-notification): Check that flymake-mode is active before calling flymake report function. #468: joaotavora/eglot#468 #472: joaotavora/eglot#472
jollaitbot
pushed a commit
to sailfishos-mirror/emacs
that referenced
this pull request
Oct 12, 2022
Also fix joaotavora/eglot#472. Copyright-paperwork-exempt: yes * eglot.el (eglot-handle-notification): Check that flymake-mode is active before calling flymake report function. GitHub-reference: fix joaotavora/eglot#468
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #468.
To reproduce this bug on master:
M-x flymake-mode. You will see the flymake overlay annotations disappear.