Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always search for the full package name in existing IMPORT-FROMs #593

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Always search for the full package name in existing IMPORT-FROMs #593

wants to merge 3 commits into from

Commits on Apr 26, 2023

  1. Always search for the full package name in existing IMPORT-FROMs 

    .. As opposed to just looking at prefixes. Previously, If you had an existing defpackage like this:

(defpakage :foo
  (:import-from :bar/car
                :find)))

And you imported bar::position, you'll end up with something ugly like this:

(defpackage :foo
  (:import-from :bar
                :position/car
                :find))
    @tdrhq
    tdrhq committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    9d7f40b View commit details
    Browse the repository at this point in the history

  2. Ensure we also handle empty IMPORT-FROMs 

    e.g. (:import-from :foo).
    @tdrhq
    tdrhq committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    256f59e View commit details
    Browse the repository at this point in the history

  3. Remove debugging statements

    @tdrhq
    tdrhq committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    ca661e7 View commit details
    Browse the repository at this point in the history