Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone (CET) causes events shown 1h later #45

Closed
estradis opened this issue Feb 2, 2018 · 20 comments
Closed

Timezone (CET) causes events shown 1h later #45

estradis opened this issue Feb 2, 2018 · 20 comments
Labels
Milestone

Comments

@estradis
Copy link

estradis commented Feb 2, 2018

We faced an issue about tb-sync. When a new event is created, it will sync with timezone "CET" but "Europe/Berlin" is expected. This leads to all events showing wrong times (1h later) in groupware and all other syncing clients.

To be sure that tb-sync causes the problem, we testet several other clients:

  1. Smartphone (Android) => OK
  2. Windows Active-Sync (Mail, Calendar, Tasks, Contatcs) => OK
  3. Microsoft Outlook => OK
  4. Thunderbird with tb-sync installed => ERROR!

As I don't know the behaving using other timezones, I would strongly recommend to make the timezone user configurable. (Especially when server and clients are located in different time zones.)

If you need further information, feel free to contact me.
And by the way, Great addon!

2018-02-02 12_53_33- admin-684 1h zeitversatz eines termins zwischen tbsync und tine

@estradis estradis changed the title Wrong Timezone (CET) causes events shown 1h later Timezone (CET) causes events shown 1h later Feb 2, 2018
@jobisoft
Copy link
Owner

jobisoft commented Feb 2, 2018

I send the timezone used during the creation of the event. Maybe the default timezone of your thunderbird is not set to Europe/Berlin?

You can enable the display of the timezone field:

image

Are you sure TbSync is sending a different timezone from what is set in the event?

@jobisoft
Copy link
Owner

jobisoft commented Feb 2, 2018

What I also do not understand: CET and Berlin/Europe share the same UTC offset and I am not able to create an event with CET timezone at all (it is not in the list). Can you share a screenshoot and how you where able to create such an event in Thunderbird?

@estradis
Copy link
Author

estradis commented Feb 5, 2018

Thank you for your quick reply. Meanwhile we also had another major issues with tb-sync randomly changing events data, so there was a decision made by the CTO to immediately ban tb-sync. Therefore I'm not longer able to share screenshots, but I'm willing to help as much as possible on this issue.

Thank you also for providing the screenshot. I didn't mind on that setting, so I'm unable to say what it was set to.

By the way CET is not automatically the same as "Europe/Berlin". Indeed it is only one part of it. The other part ist CEST, depending on summer or winter time.

And for your information:

  • Our groupware is tine20 (Demo at https://demo.tine20.net/)
  • We used active sync on thunderbird with tb-sync as well as with android

@jobisoft
Copy link
Owner

jobisoft commented Feb 5, 2018

Could you give more details on the "changing data" issue, so that this could be fixed? In 0.7.3 I think I changed the title of tasks which where placed in event folders and of events that where placed in tasks folders. This has been reverted in the 0.7.4 (which is not yet released) to an error report. Is this what you are talking about or is it something else?

Feedback on this topic would be great.

Just to make sure: This is "TbSync" not "tb-sync".

@jobisoft
Copy link
Owner

jobisoft commented Feb 5, 2018

CET has a different daylight saving behavior than Europe/Berlin? You sure about that?

@estradis
Copy link
Author

estradis commented Feb 5, 2018

Sorry for misspelling TbSync.
There were several issues on changing events:

  1. Start- and/or end times were changed (randomly?)
  2. The organisator was captured
  3. The attendees were deleted

Unfortunatly I have only the debug.log from the last issue (3), but it will take a terrible long time to anonmyze. Is the account in line 2 still active? (I will send it there, without anonmyzing)

@jobisoft
Copy link
Owner

jobisoft commented Feb 5, 2018

I just released 0.7.4-beta4, which does not alter titles of wrong items anymore. I do not know of any other situation, where TbSync does change data.

@estradis
Copy link
Author

estradis commented Feb 5, 2018

CET has a different daylight saving behavior than Europe/Berlin? You sure about that?

Technically not, but per definition CET is not CEST and both are Europe/Berlin. (Learnd at flight school)

@estradis
Copy link
Author

estradis commented Feb 5, 2018

Ok, the account is active. => Email sent

@jobisoft
Copy link
Owner

For the record: There is something wrong with my timezone methods and summer/winter-time.

  1. Created in Outlook.com

** Tue Mar 13 2018 20:54:41 GMT+0100 **
[Recieve TZ] : Before DST
utcOffset: -60
standardName: W. Europe Standard Time
standardDate: 0-10-5, 3:0:0.0
standardBias: 0
daylightName: (UTC+01:00) Amsterdam, Berlin, B
daylightDate: 0-3-5, 2:0:0.0
daylightBias: -60

** Tue Mar 13 2018 20:54:41 GMT+0100 **
[Recieve TZ] : After DST
utcOffset: -60
standardName: W. Europe Standard Time
standardDate: 0-10-5, 3:0:0.0
standardBias: 0
daylightName: (UTC+01:00) Amsterdam, Berlin, B
daylightDate: 0-3-5, 2:0:0.0
daylightBias: -60

  1. Modified in Thunderbird, synced back to outlook.com

[Send TZ] : After DST2
utcOffset: -120
standardName: (GMT+02:00) Europe/Zaporozhye
standardDate: 0-0-0, 0:0:0.0
standardBias: 0
daylightName: (GMT+02:00) Europe/Zaporozhye
daylightDate: 0-0-0, 0:0:0.0
daylightBias: 0

** Tue Mar 13 2018 20:56:19 GMT+0100 **
[Send TZ] : Before DST2
utcOffset: -60
standardName: (GMT+01:00) Europe/Berlin
standardDate: 0-0-0, 0:0:0.0
standardBias: 0
daylightName: (GMT+01:00) Europe/Berlin
daylightDate: 0-0-0, 0:0:0.0
daylightBias: 0

  1. Synced fresh from Outlook back to Thunderbird

** Tue Mar 13 2018 20:57:34 GMT+0100 **
[Recieve TZ] : After DST2
utcOffset: -120
standardName: South Africa Standard Time
standardDate: 0-0-0, 0:0:0.0
standardBias: 0
daylightName: (UTC+02:00) Harare, Pretoria
daylightDate: 0-0-0, 0:0:0.0
daylightBias: 0

** Tue Mar 13 2018 20:57:34 GMT+0100 **
[Recieve TZ] : Before DST2
utcOffset: -60
standardName: W. Central Africa Standard Time
standardDate: 0-0-0, 0:0:0.0
standardBias: 0
daylightName: (UTC+01:00) West Central Africa
daylightDate: 0-0-0, 0:0:0.0
daylightBias: 0

jobisoft added a commit that referenced this issue Mar 13, 2018
todo:
- standardDate and daylightDate (parse dateTime.timezone?)
- what happens, if event crosses DST date?
@jobisoft
Copy link
Owner

jobisoft commented Mar 13, 2018

I think it is fixed now (could not test against Tine yet), but it was not limited to Tine. I could observe the change of times for events in the summer time, if they where synced back and forth.

I did not separate the basic utcOffset and the daylightBias, but stuffed both into the utcOffset. Tbsync than added the bias to changed incoming events, so everytime an event was edited and synced, TbSync added 1 hour to the event time.

@jobisoft
Copy link
Owner

jobisoft commented Mar 20, 2018

It looks like timezone support in Tine is very strange:

image

This was created just within Tine, TbSync was not involved.

  1. Set default TimeZone of Tine to Rome
  2. Create Event
  3. Set default TimeZone of Tine to Moskau
  4. Create Event

You can see, that Tine will use the LOCAL time of the events in the global view (without any timezone information). Thunderbird - for example - always calculates the time of the event in the default timezone of the user for the global view and only displays the timezone specific time in the edit window (including the timezone information, as Tine does).

@jobisoft
Copy link
Owner

jobisoft commented Mar 20, 2018

The above finding results in "moving events" in the global view, if the timezone of events are changed.

@jobisoft
Copy link
Owner

Also, Tine does not obey timezones of incomming events. This is what I send:

[Send TZ] : Lord-Howe
utcOffset: -630
standardName: Australia/Lord_Howe
standardDate: 0-4-1, 0, 2:0:0.0
standardBias: 0
daylightName: Australia/Lord_Howe
daylightDate: 0-10-1, 0, 2:0:0.0
daylightBias: -30

And this is how it comes back:

[Recieve TZ] : Lord-Howe
utcOffset: -180
standardName:
standardDate: 0-0-0, 0, 0:0:0.0
standardBias: 0
daylightName:
daylightDate: 0-0-0, 0, 0:0:0.0
daylightBias: 0

Which is Moskau, the default TZ of Tine at that moment. Tine may use its default TZ to display the times in the global view, but it may not change the TZ itself. Furthermore, it would be nice, if Tine would actually include Europe/Moskau in the standardName/daylightName (Tine is using IANA names internally, so why not send them?). Above could also be, India/Mayotte... without a name it is hard to know...

@estradis
Copy link
Author

Opened an issue at https://forge.tine20.org/view.php?id=13804. I'm curious to see how it goes on.

@jobisoft jobisoft added this to the v0.7 milestone Apr 9, 2018
@crisoo
Copy link

crisoo commented Apr 11, 2018

Hi,
we have a similar issue.
We are using TbSync 0.7.7 to sync calendars from Thunderbird to WebTop (Nethserver). Our TZ is Europe/Vienna (=CEST, set on all Thunderbird clients and on all WebTop accounts).

Example:
Event is scheduled from 2:00pm to 3:00pm TZ: Europe/Vienna on Thunderbird
Event shows up from 12:00pm to 1:00pm TZ Europe/Paris (= same TZ as Vienna) in WebTop web interface.
Event shows up from 12:00pm to 1:00pm TZ Europe/Vienna in other Thunderbird clients.

@jobisoft
Copy link
Owner

jobisoft commented Apr 11, 2018

That is odd, this issue is still open because of the attendees stuff, the timezone should be fixed by now. I also have confirmation of another webtop user.

Can you please disable your webtop account in the TbSync account manager and enable debug log?

After debug log is enabled, re-enable your webtop account and start a fresh sync. How are the events coming in? Please send me the entire debug log vie email.

@crisoo
Copy link

crisoo commented Apr 12, 2018

In my case (TbSync syncing against Nethserver/WebTop5) it wasn't a bug in TbSync.
There was a timezone setting missing. After setting the correct timezone (see link below), everything looks correct.

I found the solution at:
https://community.nethserver.org/t/webtop-5-calendar-sync-problem/7200/22

Thanks for providing this tool and for your really fast response.

@jobisoft
Copy link
Owner

Glad it is working for you now and thanks for sharing the solution.

@jobisoft
Copy link
Owner

jobisoft commented Nov 4, 2018

This issue was moved to jobisoft/EAS-4-TbSync#14

@jobisoft jobisoft closed this as completed Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants