Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 version support and make tests tolerate the presence of OpenMP for system Python #155

Merged
merged 10 commits into from
Oct 18, 2023

Conversation

ogrisel
Copy link
Contributor

@ogrisel ogrisel commented Oct 16, 2023

Fixes #146.

Actually our CI does not need any update to test against the latest Python version available on conda-forge.

This PR is mostly about updating pyproject.toml and renaming VERSION_PYTHON to PYTHON_VERSION to sound more correct English.

EDIT: also tolerate the presence of OpenMP when Python is not installed via conda.

@ogrisel
Copy link
Contributor Author

ogrisel commented Oct 16, 2023

BTW I confirm that the pylatest_conda_forge build already uses Python 3.12 and test_command_line_empty passes on that environment contrary to what is reported on a gentoo env in #146.

@ogrisel ogrisel changed the title Python 3.12 version support Python 3.12 version support and make tests tolerate the presence of OpenMP for system Python Oct 17, 2023
tests/test_threadpoolctl.py Outdated Show resolved Hide resolved
tests/test_threadpoolctl.py Outdated Show resolved Hide resolved
@ogrisel
Copy link
Contributor Author

ogrisel commented Oct 17, 2023

@jeremiedbb this PR is good to go. It should speed-up the conda install of other PRs because the default solver is really really slow for some reason.

Copy link
Collaborator

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We could also stop assuming that none of the libraries of interest are linked to python itself and just remove this test, don't you think ?

@ogrisel
Copy link
Contributor Author

ogrisel commented Oct 17, 2023

We could also stop assuming that none of the libraries of interest are linked to python itself and just remove this test, don't you think ?

I think we can merge this PR as it is for now and remove this test if this happens gain in another case.

Still, it's interesting to discover that our assumptions about Python runtime dependencies were wrong (in some cases). This might be important to inform us about choices about packaging such native libraries, see for instance numpy/numpy#24857.

@jeremiedbb jeremiedbb merged commit 767e37d into joblib:master Oct 18, 2023
21 checks passed
@ogrisel ogrisel deleted the python-3.12-update-ci branch October 18, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests/test_threadpoolctl.py::test_command_line_empty regression with Python 3.12
3 participants