-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.12 version support and make tests tolerate the presence of OpenMP for system Python #155
Conversation
BTW I confirm that the |
@jeremiedbb this PR is good to go. It should speed-up the conda install of other PRs because the default solver is really really slow for some reason. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We could also stop assuming that none of the libraries of interest are linked to python itself and just remove this test, don't you think ?
I think we can merge this PR as it is for now and remove this test if this happens gain in another case. Still, it's interesting to discover that our assumptions about Python runtime dependencies were wrong (in some cases). This might be important to inform us about choices about packaging such native libraries, see for instance numpy/numpy#24857. |
Fixes #146.
Actually our CI does not need any update to test against the latest Python version available on conda-forge.
This PR is mostly about updating
pyproject.toml
and renamingVERSION_PYTHON
toPYTHON_VERSION
to sound more correct English.EDIT: also tolerate the presence of OpenMP when Python is not installed via conda.