allow units in .sample()
#5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you post an example, e.g., the example from the docs with units on to show that it gives the equivalent result? |
|
Hi Nathaniel, just merged this with a change that Yansong made (to allow a stream to be generated in a moving system, like a dwarf galaxy). Could you check that the unit handling still works as expected? I did the merge on GitHub, so am not sure whether it actually worked. I'd like to merge this soon. Thanks! |
nstarman
force-pushed
the
units_in_sample
branch
2 times, most recently
from
0dac4f3
to
818bbb3
Compare
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
nstarman
force-pushed
the
units_in_sample
branch
from
818bbb3
to
f2922b3
Compare
|
I rebased and pushed what I've done. Something I've been trying to figure out for a few days now is why this no longer works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow initializing Streamspraydf with units and returning unit-ful quantities in
.sample().Signed-off-by: Nathaniel Starkman (@nstarman) nstarkman@protonmail.com