Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling cross-actor tracebacks on gevent #75

Closed

Conversation

Projects
None yet
2 participants
@arnuschky
Copy link

commented Aug 24, 2017

Re #74

@arnuschky arnuschky force-pushed the arnuschky:feature-cross-actor-tracebacks branch from 6be01af to 9b14054 Aug 24, 2017

@arnuschky arnuschky force-pushed the arnuschky:feature-cross-actor-tracebacks branch from 9b14054 to 5e6ac55 Aug 24, 2017

@jodal

This comment has been minimized.

Copy link
Owner

commented Aug 25, 2017

Can you add a test or two ensuring that this keeps on working in the future?

@arnuschky

This comment has been minimized.

Copy link
Author

commented Aug 25, 2017

Sure, I'll have a look at this next week.

Note that this improved debugging in our system manifold - you can suddenly trace errors throughout the system. Game changer for us.

@jodal jodal added this to the v1.3 milestone Jan 21, 2019

@jodal jodal changed the title Enabling cross-actor tracebacks Enabling cross-actor tracebacks on gevent Jan 28, 2019

@jodal jodal closed this in 26dd5fc Feb 15, 2019

@jodal jodal self-assigned this Feb 15, 2019

@jodal

This comment has been minimized.

Copy link
Owner

commented Feb 15, 2019

When finally looking into this, I found that by removing this little if block from the existing tests, we had a failing test on gevent that proved that your fix was correct:

pykka/tests/test_future.py

Lines 121 to 124 in 0417c8b

if runtime.name == 'gevent':
# gevent prints the first half of the traceback instead of
# passing it through to the other side of the AsyncResult.
return

Fix will be in Pykka 2.0.

@arnuschky

This comment has been minimized.

Copy link
Author

commented Feb 16, 2019

hey, thanks for fixing it. Sorry for never finding the time to do it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.