Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow message to be of any type #79

Merged
merged 6 commits into from
Mar 3, 2019
Merged

Allow message to be of any type #79

merged 6 commits into from
Mar 3, 2019

Conversation

jodal
Copy link
Owner

@jodal jodal commented Mar 3, 2019

...by internally wrapping the message in an envelope for attaching metadata.

This removes all assumptions that the message is a dict, which we can
modify to piggyback our reply-to future.

Fixes #39: This change makes the example in #39 trivial to accomplish
without wrapping Pykka's Actor and Ref classes in adapters.

Fixes #45.
@jodal jodal added this to the v2.0 milestone Mar 3, 2019
@jodal jodal self-assigned this Mar 3, 2019
@codecov-io
Copy link

codecov-io commented Mar 3, 2019

Codecov Report

Merging #79 into develop will decrease coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #79      +/-   ##
==========================================
- Coverage    95.18%   94.9%   -0.29%     
==========================================
  Files           13      14       +1     
  Lines          561     569       +8     
==========================================
+ Hits           534     540       +6     
- Misses          27      29       +2
Impacted Files Coverage Δ
pykka/ref.py 100% <100%> (ø) ⬆️
pykka/messaging.py 100% <100%> (ø)
pykka/actor.py 95.34% <100%> (-1.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af4db3e...8fc0bc9. Read the comment docs.

@jodal jodal merged commit a3094e4 into develop Mar 3, 2019
@jodal jodal deleted the message-envelope branch March 3, 2019 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants