Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid Change History - org.eclipse.jgit/src/org.eclipse.jgit.api.CommitCommand#call()$try(221-292) #83

Closed
flozender opened this issue Nov 23, 2022 · 2 comments
Closed

Invalid Change History - org.eclipse.jgit/src/org.eclipse.jgit.api.CommitCommand#call()$try(221-292) #83

flozender opened this issue Nov 23, 2022 · 2 comments
Labels
body-change Reasonable body changes were made, visual similarity exists catch-finally-identical The catch block and/or finally block are identical or very similar complete-expression-change Substantial expression changes were made, little to no visual similarity incorrect-mapping Code element is mapped to a wrong element

Comments

@flozender
Copy link
Collaborator

In commit d726f0c1e02c196e2dd87de53b54338be15503f1 and file org.eclipse.jgit/src/org/eclipse/jgit/api/CommitCommand.java, element org.eclipse.jgit/src/org.eclipse.jgit.api.CommitCommand#call()$try(221-292) was identified as being finally block change, expression change, body change, which may not be accurate.

Oracle filename: jgit-CommitCommand-call-TRY_STATEMENT-1.json
@flozender
Copy link
Collaborator Author

R221 should match with L224 but it matches with L229

    {
      "parentCommitId": "bb2ca576ff4012bfc40de8bc8c7ed24276a75519",
      "commitId": "d726f0c1e02c196e2dd87de53b54338be15503f1",
      "commitTime": 1428015161,
      "changeType": "finally block change",
      "elementFileBefore": "org.eclipse.jgit/src/org/eclipse/jgit/api/CommitCommand.java",
      "elementNameBefore": "org.eclipse.jgit/src/org.eclipse.jgit.api.CommitCommand#call()$try(229-298)",
      "elementFileAfter": "org.eclipse.jgit/src/org/eclipse/jgit/api/CommitCommand.java",
      "elementNameAfter": "org.eclipse.jgit/src/org.eclipse.jgit.api.CommitCommand#call()$try(221-292)"
    },
    {
      "parentCommitId": "bb2ca576ff4012bfc40de8bc8c7ed24276a75519",
      "commitId": "d726f0c1e02c196e2dd87de53b54338be15503f1",
      "commitTime": 1428015161,
      "changeType": "expression change",
      "elementFileBefore": "org.eclipse.jgit/src/org/eclipse/jgit/api/CommitCommand.java",
      "elementNameBefore": "org.eclipse.jgit/src/org.eclipse.jgit.api.CommitCommand#call()$try(229-298)",
      "elementFileAfter": "org.eclipse.jgit/src/org/eclipse/jgit/api/CommitCommand.java",
      "elementNameAfter": "org.eclipse.jgit/src/org.eclipse.jgit.api.CommitCommand#call()$try(221-292)"
    },
    {
      "parentCommitId": "bb2ca576ff4012bfc40de8bc8c7ed24276a75519",
      "commitId": "d726f0c1e02c196e2dd87de53b54338be15503f1",
      "commitTime": 1428015161,
      "changeType": "body change",
      "elementFileBefore": "org.eclipse.jgit/src/org/eclipse/jgit/api/CommitCommand.java",
      "elementNameBefore": "org.eclipse.jgit/src/org.eclipse.jgit.api.CommitCommand#call()$try(229-298)",
      "elementFileAfter": "org.eclipse.jgit/src/org/eclipse/jgit/api/CommitCommand.java",
      "elementNameAfter": "org.eclipse.jgit/src/org.eclipse.jgit.api.CommitCommand#call()$try(221-292)"
    },

@flozender flozender added body-change Reasonable body changes were made, visual similarity exists complete-expression-change Substantial expression changes were made, little to no visual similarity catch-finally-identical The catch block and/or finally block are identical or very similar incorrect-mapping Code element is mapped to a wrong element labels Nov 30, 2022
tsantalis added a commit to tsantalis/RefactoringMiner that referenced this issue Dec 11, 2022
@tsantalis
Fix for issue jodavimehran/code-tracker#83
b7aab55
@tsantalis
Copy link
Collaborator

Screenshot from 2022-12-11 11-52-49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
body-change Reasonable body changes were made, visual similarity exists catch-finally-identical The catch block and/or finally block are identical or very similar complete-expression-change Substantial expression changes were made, little to no visual similarity incorrect-mapping Code element is mapped to a wrong element
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsantalis @flozender