-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add drops for active tubelib machines and fix end wrench crash bug #64
Conversation
Merge with the original, bringing in updates & security fixes
…tain them (#1) * Update pusher.lua * Update distributor.lua * Update pusher.lua * Update distributor.lua * Update box_copper.lua * Update box_gold.lua * Update box_steel.lua * Update autocrafter.lua * Update grinder.lua * Update liquidsampler.lua * Update quarry.lua * Update pusher_fast.lua
|
|
I tested a fix in NodeStates:on_dig_node:
However, as far as I can tell, the can_dig and on_dig callbacks that call the aforementioned function are only defined for the passive node and not the active one on each tubelib. This makes sense, as the active tubelib was never meant to be diggable. I see two options here:
|
Alternatively the replacer tool supports a blacklist. But this is no general solution, only a mod related. Better would be to add the unofficial but common used group |
This forum post highlights a number of different ways blocks can get broken when they shouldn't; I'll put together a pull request for the can_dig approach. Even if it's not the ideal solution, it fixes the immediate problem, is mod independent, and is a step in the right direction. |
Messy pull request b/c I'm a github noob
Closes #65
Closes BlockySurvival/issue-tracker#270