#150437771 implement feedback from scorecard 2 #23
Conversation
add max-len to eslin config and ensured no line wen above 80 abstract and create function to check if query result is empty and return error message
use proper naming allow users search for other users and aadmin
edit readme to reflect changes
| ); | ||
| done(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Expected a newline before ')' function-paren-newline
| expect(res.status).to.equal(404); | ||
| expect(res.body.message).to.equal( | ||
| 'user does not exist or has been previously deleted' | ||
| ); |
There was a problem hiding this comment.
Unexpected newline before ')' function-paren-newline
| .set({ Authorization: adminToken }) | ||
| .end((err, res) => { | ||
| expect(res.status).to.equal(404); | ||
| expect(res.body.message).to.equal( |
There was a problem hiding this comment.
Unexpected newline after '(' function-paren-newline
| ); | ||
| done(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Expected a newline before ')' function-paren-newline
| expect(res.status).to.equal(401); | ||
| expect(res.body.message).to.equal( | ||
| 'user making this request cannot be authenticated' | ||
| ); |
There was a problem hiding this comment.
Unexpected newline before ')' function-paren-newline
| .end((err, res) => { | ||
| expect(res.status).to.equal(404); | ||
| expect(res.body.message).to.equal('user does not exist or has been previously deleted'); | ||
| expect(res.body.message).to.equal( |
There was a problem hiding this comment.
Unexpected newline after '(' function-paren-newline
| expect(res.body.documents[0].access).to.equal('role'); | ||
| done(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Expected a newline before ')' function-paren-newline
| expect(res.body.documents[0].access).to.equal('role'); | ||
| expect(res.body.message).to.equal( | ||
| 'No document associated with this user' | ||
| ); |
There was a problem hiding this comment.
Unexpected newline before ')' function-paren-newline
| expect(res.body).include.keys(['documents']); | ||
| expect(res.body.documents[0].title).to.equal('A new title'); | ||
| expect(res.body.documents[0].access).to.equal('role'); | ||
| expect(res.body.message).to.equal( |
There was a problem hiding this comment.
Unexpected newline after '(' function-paren-newline
| ); | ||
| done(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Expected a newline before ')' function-paren-newline
What does this PR do?
This PR improves code quality and implements the feedback gotten from second scorecard
Description of Task to be completed?
Nil
How should this be manually tested?
Nil
Any background context you want to provide?
This is an implementation of feedback gotten from scorecard.
What are the relevant pivotal tracker stories?
Implement feedback from score card
Screenshots (if appropriate)
Nil
Questions:
Nil