Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntelliSense, suggest snippet insertion for overriding inherited events and functions. #77

Closed
Scrivener07 opened this issue Jun 28, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request language service

Comments

@Scrivener07
Copy link
Collaborator

Scrivener07 commented Jun 28, 2019

Describe the bug
This sounds a little like issue #44.
IntelliSense should suggest snippet insertions in child scripts for overriding inherited events and functions. The majority of scripts work by overriding inherited native base events with an implementation in children scripts.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new script.
  2. Attempt to implement the OnInit event which is inherited on every script for skyrim and fallout.
  3. Notice there are no suggestions, and events must be typed out along with their parameters.
@Scrivener07 Scrivener07 added bug Something isn't working language service labels Jun 28, 2019
@joelday joelday added the enhancement New feature or request label Jun 28, 2019
@minkir014
Copy link

So, Is that a problem with intellisense or snippets system?

I mean If snippets isn't filling the appropriate arguments so It's not a problem with intellisense?
but if you mean when you type ordinary script without using snippets auto suggestion doesn't work then It's a problem with intellisense..

@Scrivener07
Copy link
Collaborator Author

This is more of an enhancement than a bug for IntelliSense. More accurately the language service which powers the IntelliSense widget.

None of the contextually aware suggestions within IntelliSense are snippets at all. The IntelliSense widgets displays snippets in its list but they are not truly part of the IntelliSense system.
These snippet entries are marked with the snippet icon (Snippet_16x) and are not truly part of the language service.

I bring this up because if your getting an OnInit snippet suggestion then you are using another Papyrus extension alongside this one.

@minkir014
Copy link

minkir014 commented Jun 29, 2019

I understand that they are separate but I said what I understood from your title..

IntelliSense, suggest snippet insertion for overriding inherited events and functions.

So It's a problem with intellisense and suggestion not the snippets. Is that right??

@joelday joelday removed the bug Something isn't working label Jun 30, 2019
@joelday
Copy link
Owner

joelday commented Jun 30, 2019

@minkir014 This is just a feature request that is equivalent of what C# provides when you begin typing overrides.

joelday added a commit that referenced this issue Jun 30, 2019
joelday pushed a commit that referenced this issue Jun 30, 2019
# [2.15.0](v2.14.0...v2.15.0) (2019-06-30)

### Features

* Typing function or event names in definition blocks provides override autocompletion. [#77](#77) ([24af097](24af097))
@joelday joelday closed this as completed Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request language service
Projects
None yet
Development

No branches or pull requests

3 participants