Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug(s) with "useClick:true" 1.6.0 #31

Closed
Spuds opened this issue Mar 24, 2013 · 4 comments
Closed

Bug(s) with "useClick:true" 1.6.0 #31

Spuds opened this issue Mar 24, 2013 · 4 comments
Assignees

Comments

@Spuds
Copy link

Spuds commented Mar 24, 2013

Using the example page at http://users.tpg.com.au/j_birch/plugins/superfish/#

  1. Chrome 25:
  • Flush cache ;)
  • Go directly to require click tab
  • Select a menu item
    • Select one of the resulting menu items that has an additional menu (a 2nd level menu)
  • Click outside of that menu ... they never close ... e.g. two levels of menu stay open on the screen
  1. FF 19:
  • Flush cache
  • Go directly to require click tab
  • Select a menu item
    • Select one of the resulting menu items that has an additional menu (a 2nd level menu)
  • Works as expected
  • Do it again and the 2nd level menu simply appears and disappears
@joeldbirch
Copy link
Owner

Thanks, I'll have a look at this.

@ghost ghost assigned joeldbirch Mar 24, 2013
@joeldbirch
Copy link
Owner

v1.6.2 fixes the Firefox bug.

It's not clear to me whether the first part of this issue is a bug. Obviously it would be preferrable for the behaviour to be consistent across browsers, but which is correct? Firefox or Chrome? If the feature is useClick, should not the submenus stay open until clicked, given that useClick currently applies to opening and closing the submenus? I bet there are good arguments both for and against.

@joeldbirch
Copy link
Owner

I'll close this issue as the main bug is fixed. Feel free to open a separate issue to discuss the "staying open" thing.

@joeldbirch
Copy link
Owner

My fix for the Firefox thing wasn't good. It blocked links with subs from being followed in Firefox! Have pushed an update to fix that, but this issue now needs a real fix, so it is being reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants