Skip to content
This repository has been archived by the owner on Jun 1, 2021. It is now read-only.

Automatically run dependant plugins #2

Merged
merged 1 commit into from
Dec 27, 2013

Conversation

markdalgleish
Copy link
Contributor

I love this plugin, but felt that you need to hide the dependant plugins from the end users of this project.

Now, you can use this plugin like this:

bespoke.horizontal.from('article', {
  secondary: true
});

It might be worth updating the dependencies so that they can be run multiple times without causing errors. I'm more than happy to help with that work :)

@joelpurra
Copy link
Owner

This fix (potentially) breaks other plugins, which have convenient or indexfinger as dependencies, such as jumpy and logbook. These dependencies may currently work anyways, by chance, but they are not prepared for multiple deck activations.

I'm planning to accept this pull request, then modify it a bit. First I need to patch convenient with automatic dependency checking and activation.

Further discussion in bespoke-convenient issue #2, allow for automatic dependency checking, per deck activation.

Thanks!

joelpurra added a commit that referenced this pull request Dec 27, 2013
Automatically run dependant plugins
@joelpurra joelpurra merged commit 7d955b9 into joelpurra:master Dec 27, 2013
@joelpurra
Copy link
Owner

@markdalgleish: thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants