Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First pass at /about #82

Merged
merged 15 commits into from
Nov 14, 2021
Merged

First pass at /about #82

merged 15 commits into from
Nov 14, 2021

Conversation

joemasilotti
Copy link
Owner

Still need to tweak the copy here, but I think it's coming along nicely!

@joemasilotti joemasilotti mentioned this pull request Nov 11, 2021
Closed
@joemasilotti joemasilotti marked this pull request as ready for review November 11, 2021 19:58
@joemasilotti
Copy link
Owner Author

This is ready to deploy code-wise, but I'd love a second/third pass on the copy.

@joemasilotti
Copy link
Owner Author

This PR also removes lefthook.

In theory, I love the idea of running standardrb on commit. In practice, it is too slow and gets in the way of my workflow. The alternative is to install a linter in your text editor or IDE. I'm using ale in my vim config.

CC @lsparlin

@joemasilotti joemasilotti added the help wanted Looking for help from the community label Nov 12, 2021
@joemasilotti joemasilotti merged commit 12a685a into main Nov 14, 2021
@joemasilotti joemasilotti deleted the about-page branch November 14, 2021 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vamsipavanmahesh vamsipavanmahesh vamsipavanmahesh left review comments

Assignees
No one assigned
Labels
help wanted Looking for help from the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joemasilotti @vamsipavanmahesh