jssrc2cpg: Default Parameters Show Default in .code #2777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, while default parameter semantics are modelled in the CPG, there is no easy query for "Does this parameter have a default value?". Now ideally, there would be some `MethodParameterIn(defaultValue: Option[String])` or `MethodParameterIn -DEFAULT-> Literal` construct in the schema, but this is a quick-and-dirty way to easily show a parameter is assigned a default.
|
Which field are we changing here? |
|
@fabsx00 only the |
|
Alright. |
max-leuthaeuser
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, while default parameter semantics are modelled in the CPG, there is no easy query for "Does this parameter have a default value?".
Now ideally, there would be some
MethodParameterIn(defaultValue: Option[String])orMethodParameterIn -DEFAULT-> Literalconstruct in the schema, but this PR is a quick-and-dirty way in the meantime to easily show a parameter is assigned a default.