fix jssrc astgen invocation on linux/aarch64 #4671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't like the amount of code we have there that pretends as if "ARM" is a single architecture... so I've moved things in a slightly better direction renaming some constants to ARMv8. But I'm not going to fix that all in one day.
mpollmeier
approved these changes
Jun 17, 2024
| @@ -50,20 +51,15 @@ astGenBinaryNames := { | |||
| if (hasCompatibleAstGenVersion(astGenVersion.value)) { | |||
| Seq.empty | |||
| } else if (sys.props.get("ALL_PLATFORMS").contains("TRUE")) { | |||
| Seq(AstgenWin, AstgenLinux, AstgenMac, AstgenMacArm) | |||
| Seq(AstgenWin, AstgenLinux, AstgenLinuxArm, AstgenMac, AstgenMacArm) | |||
There was a problem hiding this comment.
AstgenLinuxArmV8? since you added v8 elsewhere..?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't like the amount of code we have there that pretends as if "ARM" is a single architecture... so I've moved things in a slightly better direction renaming some constants to ARMv8. (But I'm not going to fix that all completely in one day.)
The downloaded binaries actually already exist, just the integration here was missing.