ignore case while matching excluded files #4697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise specifying one variant might not match the same file on e.g. Windows systems, when in fact it should match.
Ferada
force-pushed
the
olof/fix/ignore-case-while-matching-excluded-files
branch
from
da9c42e
to
294f771
Compare
max-leuthaeuser
approved these changes
Jun 27, 2024
max-leuthaeuser
requested changes
Jul 2, 2024
ml86
approved these changes
Jul 2, 2024
max-leuthaeuser
approved these changes
Jul 2, 2024
|
Side info: MacOS also has a case insensitive filesystem by default. |
max-leuthaeuser
deleted the
olof/fix/ignore-case-while-matching-excluded-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise specifying one variant might not match the same file on e.g. Windows systems, when in fact it should match. This PR replaces the path comparisons with case-insensitive ones.
Test cases are happy, but I don't have a Windows one to test this. Ideally the comparisons should be purely on the paths, but instead there's an
isDirectorycall in there - it might be better (faster) to require callers to specify the ending slash/for directories instead and get rid of that case.c.f. https://shiftleft.zendesk.com/agent/tickets/102700 and https://shiftleftsecurity.slack.com/archives/CE822HDC1/p1719386396027259
https://shiftleftinc.atlassian.net/browse/SEN-2828