[ruby] Calls with reserved keywords #4776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…local identifiers to check for keywords and member access
…: syntax and having a base with the same name as a reserved keyword
|
cc @spingARbor: This bug affected a lot of GitLab files (#4732), so once it's merged there will be a lot more content. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue was picked up where having a reserved keyword as the call on a member (e.g.
batch.retry!) was causing a syntax error due to lexer and parser issues.This PR handles:
LOCAL_VARIABLE_IDENTIFIERLOCAL_VARIABLE_IDENTIFIERtokens to determine whether a token should be marked as reserved keyword or not. We check if the previousnonWstoken is.,:or::, or if the next token is.or:. If this holds, we know it cannot be a reserved keyword and is instead marked as aLOCAL_VARIABLE_IDENTIFIER.Resolves #4748