Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage #22

Closed
29 tasks done
joeroe opened this issue Nov 11, 2020 · 1 comment
Closed
29 tasks done

Test coverage #22

joeroe opened this issue Nov 11, 2020 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@joeroe
Copy link
Owner

joeroe commented Nov 11, 2020

  • yr()
  • yr get and set functions
    • yr_era() returns correct era
    • yr_era()<- and yr_set_era() set correct era
  • era()
    • Returns class era with valid input
    • Expect error for invalid input
  • eras()
    • Returns correct row for exact match
    • Returns correct row for partial match
    • eras() returns all rows from era_table
    • All eras defined in eras() are valid
  • era_parameters
    • Return correct output for all getters
  • yr_transform()
    • dst_era is correct
    • All significant transformations return correct result
    • Expect error for incomparable units
    • No errors for otherwise possible transformations
  • vctrs classes (suggestions: https://vctrs.r-lib.org/articles/s3-vector.html#testing-1)
    • expect_snapshot_output() of format.era_yr()
    • expect_snapshot_output() of format.era()
    • Method symmetry
    • Expect errors for inputs that can't be combined
  • vctrs arithmetic
  • era_year()
@joeroe joeroe added this to the v1.0 milestone Nov 11, 2020
@joeroe joeroe added the enhancement New feature or request label Nov 11, 2020
joeroe added a commit that referenced this issue Nov 11, 2020
joeroe added a commit that referenced this issue Nov 13, 2020
@joeroe joeroe pinned this issue Dec 10, 2020
@joeroe joeroe modified the milestones: 1.0.0, 0.4.0 Feb 7, 2021
@joeroe
Copy link
Owner Author

joeroe commented Mar 9, 2022

851cc6d reached 98% (I'm not sure it's actually possible to reach stop_incompatible_op() in yr arithmetic methods), which I think is good enough.

@joeroe joeroe closed this as completed Mar 9, 2022
@joeroe joeroe unpinned this issue Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant