Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/nls fix translation installation, closes #565 #564 #556 #566

Merged
merged 2 commits into from
May 15, 2022

Conversation

01micko
Copy link
Contributor

@01micko 01micko commented May 15, 2022

There are 2 commits here that address some recent issues:

  1. a146962 addresses a minor issue with some syntax errors in po/pt_BR in the comments at the top of the file closing pt_BR translation causes error in make #564
  2. 607fc3d adds AM_INIT_AUTOMAKE to configure.ac fixing a bug where @mkdir_p@ was undefined in po/Makefile causing the failure of .mo files to be installed addressing Translations not installing - automake (GNU automake) 1.16.2 #565 and Obsolete @mkdir_p@ macro in po/Makefile.in.in #556

I tested this by trying to upgrade the autotools but that failed for me, so I researched a little and found that AM_INIT_AUTOMAKE absence may have been the cause. I duely tried that and this fix works with automake-1.16.2 and automake-1.16.5, both with gettext-0.21.

Thanks @joewing for your consideration of these commits.

This caused creation of po/*gmo files to stop so the last few
were not completed.
This fixes installation where in po/Makefile @mkdir_p@ was not
defined and caused po/*gmo translations installation failure
@01micko
Copy link
Contributor Author

01micko commented May 15, 2022

@joewing you may also want to consider this - #432 (comment)

Especially if you decide if this PR isn't warranted.

@joewing
Copy link
Owner

joewing commented May 15, 2022

Thanks! I don't see any reason not to merge these.
As far as cmake is concerned... that branch is a bit out of date and I don't think handles everything. autotools are somewhat confusing, but they're everywhere and JWM already uses them so it might not be worth the effort to convert.

@joewing joewing merged commit 05397d5 into joewing:master May 15, 2022
@01micko 01micko deleted the bugfix/nls branch May 16, 2022 04:16
@01micko
Copy link
Contributor Author

01micko commented May 16, 2022

Thanks Joe 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants