Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downloaded files are not being cached #127

Closed
joeyespo opened this issue Jun 1, 2015 · 2 comments
Closed

Downloaded files are not being cached #127

joeyespo opened this issue Jun 1, 2015 · 2 comments
Labels
bug

Comments

@joeyespo
Copy link
Owner

joeyespo commented Jun 1, 2015

With the new behavior in b28a992, the cache is not being created because the asset downloads are 404'ing.

Looks like the style asset regular expression might need updated.
@joeyespo joeyespo added the bug label Jun 1, 2015
@joeyespo
Copy link
Owner Author

joeyespo commented Jun 1, 2015

This might be related to what was going on in #95.

@joeyespo
Copy link
Owner Author

Fixed in 3eabaf9.

Turns out, using requests.text was the underlying issue. We needed to use requests.raw to get the binary data and then save that without any sort of unicode handling.

This was referenced Oct 18, 2016
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joeyespo