Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine whether to use package_data or data_files #23

Closed
joeyespo opened this issue Aug 16, 2013 · 2 comments
Closed

Determine whether to use package_data or data_files #23

joeyespo opened this issue Aug 16, 2013 · 2 comments
Labels
research

Comments

@joeyespo
Copy link
Owner

Since I broke the install by removing package_data, and @briancappello fixed it with data_files in #21, some research needs to be done to determine which is currently the best approach, or if there's even a newer best-practice now.
@briancappello
Copy link
Contributor

@joeyespo Looks like you were right to have been using package_data. data_files appears best suited for "manually copying" data files that aren't included within any Python packages. Thanks for raising this issue 👍

http://stackoverflow.com/questions/4519127/setuptools-package-data-folder-location
http://stackoverflow.com/questions/5192386/installing-my-sdist-from-pypi-puts-the-files-in-unexpected-places
http://pythonhosted.org/distribute/setuptools.html#including-data-files

@briancappello briancappello mentioned this issue Aug 22, 2013
Merged
@joeyespo
Copy link
Owner Author

Thanks for looking into this! =)

@alexandrul alexandrul mentioned this issue Jan 27, 2017
Closed
rodrigondec added a commit to imobanco/icnab240 that referenced this issue May 15, 2020
@rodrigondec
recursive-include no manifest
144d382 
https://wiki.python.org/moin/Distutils/Tutorial
https://python-packaging.readthedocs.io/en/latest/metadata.html
joeyespo/grip#23
https://stackoverflow.com/a/5423147
rodrigondec added a commit to imobanco/icnab240 that referenced this issue May 18, 2020
@rodrigondec
Pacote 'criado' (#34)
93bd6b5 
* setup & versioneer

* pacote renomeado

* readme adicionado

* readme.md agora é contributing

* texto da zoop removido

* url atualizada

* include_package_data com verdadeiro

https://python-packaging.readthedocs.io/en/latest/non-code-files.html

* include package_data

* corrigido package_data

* recursive-include no manifest

https://wiki.python.org/moin/Distutils/Tutorial
https://python-packaging.readthedocs.io/en/latest/metadata.html
joeyespo/grip#23
https://stackoverflow.com/a/5423147

* sem recursive include

* nome da variável do diretório alterado

* PYPI deploy no CI

* fix imports

* black
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
research
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joeyespo @briancappello