Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding password prompting in login #154

Merged
merged 1 commit into from
Dec 7, 2015

Conversation

mekoda
Copy link
Contributor

@mekoda mekoda commented Dec 7, 2015

No description provided.

@mekoda
Copy link
Contributor Author

mekoda commented Dec 7, 2015

I was going to suggest to verify login right after the user input, but I think the most suitable effort here is to work on issue #82 and ensure this too. This will lead to a more responsive experience, in which entering wrong credentials will not even execute anything.

@joeyespo
Copy link
Owner

joeyespo commented Dec 7, 2015

Wow, I had no idea about the builtin getpass package. Learn something new every day 😃

Thanks for this simple implementation, it looks good.

@joeyespo
Copy link
Owner

joeyespo commented Dec 7, 2015

I was going to suggest to verify login right after the user input, but I think the most suitable effort here is to work on issue #82 and ensure this too.

Just noticed this comment. Yeah, that seems fine to defer validation since it's nontrivial. Ready to pull this in once --pass is back.

@mekoda
Copy link
Contributor Author

mekoda commented Dec 7, 2015

Done.

@joeyespo
Copy link
Owner

joeyespo commented Dec 7, 2015

Excellent. Thank you, @mekoda! Will release soon.

joeyespo added a commit that referenced this pull request Dec 7, 2015
@joeyespo joeyespo merged commit 1ece5fc into joeyespo:master Dec 7, 2015
@joeyespo joeyespo mentioned this pull request Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants