Fix #38 #39
Merged
Fix #38 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this would have created a '~' directory in the current dir. Now, this resolves homedirs first.
| @@ -22,7 +22,7 @@ def create_app(path=None, gfm=False, context=None, username=None, password=None, | |||
| raise ValueError('File not found: ' + path) | |||
|
|
|||
| # Flask application | |||
| app = Flask(__name__) | |||
| app = Flask(__name__, instance_path=os.abspath(os.path.expanduser("~/.grip"))) | |||
There was a problem hiding this comment.
Yes. I'll fix the patch.
|
+1 |
|
I think #52 implements a better solution. |
|
@kynan Can you explain why you think that's a better solution? Is there any situation where you need to change the instance directory away from I'm going to merge this variation in until there's a compelling reason to add another configuration option. Every option makes the project just a little bit more complex. |
joeyespo
added a commit
that referenced
this pull request
Jul 20, 2014
|
Thanks for the PR, @swsnider! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly set the instance_path parameter to Flask so that when the app is installed, it doesn't try to write to a privileged directory.