Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not overwrite config.json while restoring if json syntax error #93

Open
vnadot opened this issue Mar 20, 2022 · 1 comment
Open

do not overwrite config.json while restoring if json syntax error #93

vnadot opened this issue Mar 20, 2022 · 1 comment

Comments

@vnadot
Copy link

vnadot commented Mar 20, 2022

Hi,
I just discovered your software, it seems a really nice tool, congrats !
I've noticed that if there is a syntax error in config.json, then lwsm overwrites it with its default value when restoring a config. This behavior seems to me annoying because you can loose your own config (eg the mapping you have defined in WM_CLASS_AND_EXECUTABLE_FILE_MAP) if you didn't save/version it before.
I would propose to:

  • add a print in a terminal when this case happens
  • stop the restore or at least save the current config.json to config_20210320_120034.json and then resume the restore
    Best regards,
    Victor
@vnadot vnadot changed the title do not overwrite config.json if json syntax error when restoring do not overwrite config.json while restoring if json syntax error Mar 20, 2022
@johannesjo
Copy link
Owner

Thanks for opening this up. PRs are welcome, we also would need to consider the case, if this is run from the gnome shell widget though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants