New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual testing #12

Closed

johansatge opened this issue Nov 28, 2018 · 1 comment

Labels

Owner

johansatge commented Nov 28, 2018

As seen in #11, the existing tests are not enough.

Let's try to introduce visual testing, to make sure the resulting image has been rotated/flipped correctly.

Possible workflow:

After rotating the test images, write them on disk
Capture the original image with an EXIF-friendly tool (by taking a screenshot with Chrome + puppeteer, for instance?)
Run a visual comparison between the two images (with pixelmatch for instance)

johansatge added the enhancement label

This was referenced Nov 28, 2018

Rotation and flip bug? #11

Closed

Merged

Owner Author

johansatge commented Oct 5, 2019

Done in #14.

johansatge closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment