Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS] reference rendering #76

Closed
faroit opened this issue Jun 29, 2023 · 4 comments
Closed

[JOSS] reference rendering #76

faroit opened this issue Jun 29, 2023 · 4 comments

Comments

@faroit
Copy link
Contributor

faroit commented Jun 29, 2023

👋 @johentsch here is a few more small issues about the references in the JOSS paper

  1. the following paper (I guess ISMIR 23) should probably get a year even though it was just accepted. Otherwise try to change the rendering so that inPress isn't repeated twice.
image
  1. I guess the company is called NPC Imaging. So please change the capitalization here.
image
  1. the colon in "bigger tent". should be outside of the hyphens.
image

this is part of the JOSS review openjournals/joss-reviews#5195

@johentsch
Copy link
Owner

Thanks @faroit.

  1. I had seen already and fixed together with your PR.
  2. Done locally, they are npc Imaging, actually.
  3. This is beyond my control, as I don't control where the period is rendered. It's not part of the bibtex entry. What do you advise me to do?

@faroit
Copy link
Contributor Author

faroit commented Jun 29, 2023

Ok. Thanks. On 3. I would have to check if that's the norm. Maybe this is indeed correct then

@johentsch
Copy link
Owner

Seems more like glitch to me. As we could see from 1. the typesetting is not quite as accomplished as in LaTeX... I'll halt until your update on how to proceed.

@faroit
Copy link
Contributor Author

faroit commented Jul 7, 2023

@johentsch sorry for taking so long... I checked for 3 and it turns out that this is actually a US grammar rule and not a bug 😱

https://www.grammar-monster.com/lessons/quotation_(speech)_marks_punctuation_in_or_out.htm

So this can be closed.

@faroit faroit closed this as completed Jul 7, 2023
johentsch added a commit that referenced this issue Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants