Add CLI flag for the update source #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running tldextract --update, add a second optional parameter --update_source To specify a local file or URL to update from. This could be useful if the mozilla public subdomain list is not easily accessable due to a firewall, or if a costom subdomain list is in use.
|
Holy 2 year bump. 😓 I was previously loathe to expand the CLI, but I now begin to understand the common request. For this PR, I fixed conflicts, renamed the flag for consistency, and passed the new list as an argument vs. mutating an object later. I'll noodle on that last one. I don't think the partially constructed object was intentional. |
|
Wow! two years! I don't know if you are waiting for some sort of comment or approval from me, but if you need it, then I would be pleased if you would merge this PR, and while the change in the command line switch will be an inconvenience for me, it is not a reason to delay the merge or edit it further. Please merge this ASAP. |
|
I'm glad you're still around and find it useful! This PR seems good to me then! |
john-kurkowski
changed the title
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jun 16, 2022
https://build.opensuse.org/request/show/982862 by user mia + dimstar_suse - Update to 3.3.0 Features * Add CLI flag `--suffix_list_url` to set the suffix list URL(s) or source file(s) (#gh/john-kurkowski/tldextract#197) * Add CLI flag `--no_fallback_to_snapshot` to not fall back to the snapshot (#gh/john-kurkowski/tldextract#260) * Add alias `--include_psl_private_domains` for CLI flag `--private_domains` Bugfixes * Handle more internationalized domain name dots (#gh/john-kurkowski/tldextract#253) Misc. * Update bundled snapshot * Add basic CLI test coverage Changes in 3.2.1: Bugfixes * Fix incorrect namespace used for caching function returns (#gh/john-kurkowski/tldextract#258) Changes in 3.2.0: Features * Add types to the public API (#gh/john-kurkowski/tldextract#244) Bugfixes * Add support for Python 3.10, dr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an --update_source command line option to the command line interface.
The intended use, is that in production we don't want the delay associated with the default behaviour of updating when the API is called for the first time. This change also makes it possible to change the update URL without changing our main application, just the setup scripts.
This could be a better way to solve the problem that PR #150 is attempting to fix.
The README.md has been updated to document the new feature, but not the changelong.